Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix comment nits in bootstrap\loaders.js #24641

Closed
wants to merge 1 commit into from
Closed

lib: fix comment nits in bootstrap\loaders.js #24641

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@vsemozhetbyt vsemozhetbyt added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 25, 2018
@vsemozhetbyt
Copy link
Contributor Author

As only comments are changed, it seems CI-lite suffices. Let me know if we need full CI.

@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor Author

Landed in 1db808c
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the lib-internal-bootstrap-loaders.js branch November 27, 2018 14:16
vsemozhetbyt added a commit that referenced this pull request Nov 27, 2018
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2018
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
GaryGSC pushed a commit to GaryGSC/node that referenced this pull request Nov 8, 2019
Backport-PR-URL: nodejs#30338

PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

(cherry picked from commit 1db808c)
BethGriggs pushed a commit that referenced this pull request Nov 22, 2019
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants