lib: set stderr._destroy to dummyDestroy #24398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr.
nodejs-github-bot
added
the
process
|
CI: https://ci.nodejs.org/job/node-test-pull-request/18680/ (I am not sure how to test this as I bumped into this while working on something else, but that gets fixed once I fixed this...) |
addaleax
approved these changes
Nov 16, 2018
cjihrig
approved these changes
Nov 16, 2018
joyeecheung
added
the
author ready
targos
approved these changes
Nov 17, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2018
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr. PR-URL: nodejs#24398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 71f4d5a |
targos
pushed a commit
that referenced
this pull request
Nov 19, 2018
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr. PR-URL: #24398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr. PR-URL: #24398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr. PR-URL: #24398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr. PR-URL: nodejs#24398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr. PR-URL: #24398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be typo: we are setting stdout._destroy instead of
stderr._destroy in the getter of stderr.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes