Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused variables #24355

Closed
wants to merge 1 commit into from
Closed

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 14, 2018

Currently the following compiler warnings are generated:

../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
  Local<Array> ary = Array::New(args.GetIsolate());
               ^
1 warning generated.
../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
  Local<Array> holder = Array::New(isolate);
               ^
1 warning generated.

This commit removes these unused variables.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Currently the following compiler warnings are generated:

../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
  Local<Array> ary = Array::New(args.GetIsolate());
               ^
1 warning generated.

../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
  Local<Array> holder = Array::New(isolate);
               ^
1 warning generated.

This commit removes these unused variables.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Nov 14, 2018
@danbev
Copy link
Contributor Author

danbev commented Nov 14, 2018

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax pushed a commit that referenced this pull request Nov 16, 2018
Currently the following compiler warnings are generated:

../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
  Local<Array> ary = Array::New(args.GetIsolate());
               ^
1 warning generated.

../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
  Local<Array> holder = Array::New(isolate);
               ^
1 warning generated.

This commit removes these unused variables.

PR-URL: #24355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Nov 17, 2018

Looks like @addaleax landed this in commit 39a5e7d.

@Trott Trott closed this Nov 17, 2018
targos pushed a commit that referenced this pull request Nov 18, 2018
Currently the following compiler warnings are generated:

../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
  Local<Array> ary = Array::New(args.GetIsolate());
               ^
1 warning generated.

../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
  Local<Array> holder = Array::New(isolate);
               ^
1 warning generated.

This commit removes these unused variables.

PR-URL: #24355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Currently the following compiler warnings are generated:

../src/node_process.cc:799:16:
warning: unused variable 'ary' [-Wunused-variable]
  Local<Array> ary = Array::New(args.GetIsolate());
               ^
1 warning generated.

../src/node_http2.cc:1294:16:
warning: unused variable 'holder' [-Wunused-variable]
  Local<Array> holder = Array::New(isolate);
               ^
1 warning generated.

This commit removes these unused variables.

PR-URL: #24355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danbev danbev deleted the unused_vars branch December 4, 2018 04:25
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants