lib: fix - invalid timer priority queue order #24318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in lib/timers.js PriorityQueue.percolateDown cannot be used for rescheduling list,
because it does not work in all cases
- updated item does not have to be root of the heap when new timers are created
in runNextTicks and then percolateDown does not solve all binary heap
inconsistencies
- old behavior could cause infinite loop timers in some cases
- added PriorityQueue.updateAt and PriorityQueue.update methods
- simple implementation by remove & insert, could be improved...
- rescheduling list uses updateAt method
nodejs-github-bot
added
the
timers
|
Thanks for info, I’ll check the priority queue for your test case... |
|
The fix is still not complete, PriorityQueue.percolateDown is not suitable method for restoring binary heap after removal of item. I have to implement updateAt method without removing and inserting the item, that wil be able to fix binary heap up and also down... It will be used in updateAt and also removeAt methods... |
|
@mareksrom sorry, I didn't see your PR earlier but I opened the correct version at #24322 which rebalances both up & down the heap. Would appreciate your review if you've got a moment. |
|
Superseded by the now merged #24322 @mareksrom Thanks for making this anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in lib/timers.js PriorityQueue.percolateDown cannot be used for rescheduling list,
because it does not work in all cases
in runNextTicks and then percolateDown does not solve all binary heap
inconsistencies
added PriorityQueue.updateAt and PriorityQueue.update methods
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes