Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: remove unreachable error #24222

Closed
wants to merge 4 commits into from
Closed

net: remove unreachable error #24222

wants to merge 4 commits into from
+7 −0

Commits on Nov 7, 2018

  1. net: remove unreachable error 

    When creating a socket, if the file descriptor is not a valid PIPE or
TCP type, createHandle throws an ERR_INVALID_FD_TYPE. This means that
`this._handle.open` is guaranteed to succeed and will never return an
error.
    @bewchy
    bewchy committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    d961de0 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. net: add comments on unreachable error check

    @bewchy
    bewchy committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    4899951 View commit details
    Browse the repository at this point in the history

  2. net: add comments explaining error check 

    This new commit re-formats the comments for linting checks
    @bewchy
    bewchy committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    f7565e6 View commit details
    Browse the repository at this point in the history

  3. net: add comments to Socket constructor 

    Co-Authored-By: bewchy <bewchabbacc@gmail.com>
    @lpinca @bewchy
    lpinca and bewchy committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    e0eb104 View commit details
    Browse the repository at this point in the history