Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: cover .assert with single argument #24188

Closed
wants to merge 1 commit into from
Closed

console: cover .assert with single argument #24188

wants to merge 1 commit into from

Conversation

mroderick
Copy link
Contributor

This PR covers console.assert with a single argument.

See https://coverage.nodejs.org/coverage-d32b5bd567544f5b/root/console.js.html#L295

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@addaleax addaleax added the console Issues and PRs related to the console subsystem. label Nov 6, 2018
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18499/

@Trott
Copy link
Member

Trott commented Nov 11, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18537/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 11, 2018
@mroderick @Trott
console: cover .assert with single argument
e3d05a6 
PR-URL: nodejs#24188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 11, 2018

Landed in e3d05a6.

@Trott Trott closed this Nov 11, 2018
@mroderick mroderick deleted the console-assert-coverage-single-argument branch November 12, 2018 07:33
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@mroderick @BridgeAR
console: cover .assert with single argument
9e89132 
PR-URL: #24188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@mroderick @kiyomizumia
console: cover .assert with single argument
f847bd6 
PR-URL: nodejs#24188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@mroderick @codebytere
console: cover .assert with single argument
d52709f 
PR-URL: #24188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@mroderick @MylesBorins
console: cover .assert with single argument
07b9a66 
PR-URL: #24188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. console Issues and PRs related to the console subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mroderick @addaleax @Trott @jasnell @BridgeAR @nodejs-github-bot