Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: add --tls-cipher-list command line switch #2412

Closed
wants to merge 1 commit into from

Commits on Aug 21, 2015

  1. tls: add --tls-cipher-list command line switch

    This adds a new `--tls-cipher-list` command line switch
    that can be used to override the built-in default cipher
    list. The intent of this is to make it possible to enforce
    an alternative default cipher list at the process level.
    Overriding the default cipher list is still permitted at
    the application level by changing the value of
    `require('tls').DEFAULT_CIPHERS`.
    
    As part of the change, the built in default list is moved
    out of tls.js and into node_constants.h and node_constants.cc.
    Two new constants are added to require('constants'):
    
      * defaultCipherList (the active default cipher list)
      * defaultCoreCipherList (the built-in default cipher list)
    
    A test case and doc changes are included.
    
    A new NODE_DEFINE_STRING_CONSTANT macro is also created in
    node_internals.h
    
    When node_constants is initialized, it will pick up either
    the passed in command line switch or fallback to the default
    built-in suite.
    
    Within joyent/node, this change had originaly been wrapped
    up with a number of other related commits involving the
    removal of the RC4 cipher. This breaks out this isolated
    change.
    
    /cc @mhdawson, @misterdjules, @trevnorris, @indutny, @rvagg
    jasnell committed Aug 21, 2015
    Configuration menu
    Copy the full SHA
    18ffd90 View commit details
    Browse the repository at this point in the history