Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix headings for CHANGELOG_v10.md #23973

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v10.x labels Oct 30, 2018
@MylesBorins MylesBorins removed the doc Issues and PRs related to the documentations. label Oct 30, 2018
@targos
Copy link
Member

targos commented Oct 30, 2018

Can it land on master first?

@MylesBorins
Copy link
Contributor Author

@targos that makes sense. It should Target master

@MylesBorins MylesBorins changed the base branch from v10.x-staging to master October 31, 2018 06:44
The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.
@MylesBorins
Copy link
Contributor Author

i've targetted against master

MylesBorins added a commit that referenced this pull request Nov 1, 2018
The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.

PR-URL: #23973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins closed this Nov 1, 2018
@MylesBorins MylesBorins reopened this Nov 1, 2018
@MylesBorins MylesBorins removed the v10.x label Nov 1, 2018
@danbev
Copy link
Contributor

danbev commented Nov 2, 2018

Landed in db2ac1d.

@danbev danbev closed this Nov 2, 2018
danbev pushed a commit that referenced this pull request Nov 2, 2018
The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.

PR-URL: #23973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants