Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: net.Server.listen() avoid operations on null when fail #23920

Closed
wants to merge 2 commits into from
Closed

net: net.Server.listen() avoid operations on null when fail #23920

wants to merge 2 commits into from

Commits on Oct 27, 2018

  1. net: net.Server.listen() avoid operations on null when fail 

    When `net.Server` fails to create a new handle, an error shall be
emitted in the next tick. Therefore, we make `net.Server.listen()`
directly  return to avoid following operations on `null`
`this._handle`.

Fixes: nodejs#23917
    @oyyd
    oyyd committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    c5764ae View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2018

  1. fixup

    @oyyd
    oyyd committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    f58c0f1 View commit details
    Browse the repository at this point in the history