Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: call destroy() on StreamWrap and their streams #23654

Closed
wants to merge 1 commit into from
Closed

tls: call destroy() on StreamWrap and their streams #23654

wants to merge 1 commit into from

Commits on Oct 14, 2018

  1. tls: close StreamWrap and its stream correctly 

    When sockets of the "net" module destroyed, they will call
`this._handle.close()` which will also emit EOF if not emitted
before. This feature makes sockets on the other side emit "end" and
"close" even though we haven't called `end()`. As `stream` of
`StreamWrap` are likely to be instances of `net.Socket`, calling
`destroy()` manually will avoid issues that don't properly close
wrapped connections.

Fixes: nodejs#14605
    @oyyd
    oyyd committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    7200e21 View commit details
    Browse the repository at this point in the history