Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move default assignment of async_id_ in async_wrap.h #23495

Closed
wants to merge 1 commit into from
Closed

src: move default assignment of async_id_ in async_wrap.h #23495

wants to merge 1 commit into from

Conversation

davesters
Copy link
Contributor

Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@davesters
src: move default assignment of async_id_ in async_wrap.h
926931e 
Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 12, 2018
@addaleax addaleax added async_wrap code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17770/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2018
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 13, 2018
@Trott
Copy link
Member

Trott commented Oct 13, 2018

Collaborators, please 👍 here to fast-track.

@Trott
Copy link
Member

Trott commented Oct 13, 2018 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/177​90

@Trott
Copy link
Member

Trott commented Oct 13, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/17804

@Trott
Copy link
Member

Trott commented Oct 13, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17818/

@Trott
Copy link
Member

Trott commented Oct 13, 2018 •
edited by addaleax
Loading

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/17825/

Again: https://ci.nodejs.org/job/node-test-pull-request/17854/

@addaleax
Copy link
Member

Landed in 8ce99fa

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Oct 14, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@davesters @addaleax
src: move default assignment of async_id_ in async_wrap.h
8ce99fa 
Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

PR-URL: #23495
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@davesters @addaleax
src: move default assignment of async_id_ in async_wrap.h
aecba73 
Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

PR-URL: #23495
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@davesters @jasnell
src: move default assignment of async_id_ in async_wrap.h
35d9990 
Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

PR-URL: #23495
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@davesters @MylesBorins
src: move default assignment of async_id_ in async_wrap.h
264d129 
Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

PR-URL: #23495
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@davesters @rvagg
src: move default assignment of async_id_ in async_wrap.h
295bb73 
Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

PR-URL: #23495
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@davesters @MylesBorins
src: move default assignment of async_id_ in async_wrap.h
84aa6b2 
Moving the default assignment of async_id from the constructor in
async_wrap.cc to class definition in async_wrap.h

PR-URL: #23495
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@addaleax addaleax addaleax approved these changes

@codebytere codebytere codebytere approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@davesters @addaleax @Trott @jasnell @thefourtheye @codebytere @cjihrig @gireeshpunathil @trivikr @nodejs-github-bot