Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix confusing language about microtask queue #23197

Merged
merged 1 commit into from
Oct 4, 2018
Merged

doc: fix confusing language about microtask queue #23197

merged 1 commit into from
Oct 4, 2018

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Oct 1, 2018

cc @addaleax

Checklist

@nodejs-github-bot
Copy link
Collaborator

@devsnek build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1086/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 1, 2018
@devsnek
Copy link
Member Author

devsnek commented Oct 4, 2018

ci lite https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1121/

@devsnek
doc: fix confusing language about microtask queue
f217201 
PR-URL: nodejs#23197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@devsnek
Copy link
Member Author

devsnek commented Oct 4, 2018

Landed in f217201

@devsnek devsnek closed this Oct 4, 2018
@devsnek devsnek merged commit f217201 into nodejs:master Oct 4, 2018
@devsnek devsnek deleted the hp1 branch October 4, 2018 06:29
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@devsnek @jasnell
doc: fix confusing language about microtask queue
5ed4b89 
PR-URL: #23197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@devsnek @nodejs-github-bot @jasnell @addaleax @cjihrig @BridgeAR @trivikr @targos