Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: error when empty buffer is passed to fs.read() #23141

Closed
wants to merge 1 commit into from
Closed

test: error when empty buffer is passed to fs.read() #23141

wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Sep 28, 2018

Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 28, 2018
test: error when empty buffer is passed to fs.read()
3bf28b1 
Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.
@danbev
Copy link
Contributor

danbev commented Oct 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17544/

@addaleax
Copy link
Member

addaleax commented Oct 1, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17557/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2018
@shisama
Copy link
Contributor Author

shisama commented Oct 1, 2018

@danbev @addaleax Thank you to run CI. However, it failed. I think the failure is caused by flaky test (#23067).

@danbev
Copy link
Contributor

danbev commented Oct 2, 2018 •
edited
Loading

Resume again: https://ci.nodejs.org/job/node-test-commit-linux/22022/ ✔️

@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@danbev
Copy link
Contributor

danbev commented Oct 3, 2018

Landed in 097896b.

@danbev danbev closed this Oct 3, 2018
danbev pushed a commit that referenced this pull request Oct 3, 2018
@danbev
test: error when empty buffer is passed to fs.read()
097896b 
Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.

PR-URL: #23141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jasnell
test: error when empty buffer is passed to fs.read()
a29631b 
Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.

PR-URL: #23141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shisama @danbev @addaleax @jasnell @lpinca @cjihrig @BridgeAR @targos @nodejs-github-bot