Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: robuster http2-large-file test #22540

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Aug 26, 2018

This makes sure the first request is not sent before the client is
ready to respond. Therefore the ECONNRESET errors should be resolved.

Fixes: #22327

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This makes sure the first request is not sent before the client is
ready to respond. Therefore the ECONNRESET errors should be resolved.

Fixes: nodejs#22327
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 26, 2018
@BridgeAR
Copy link
Member Author

@Trott
Copy link
Member

Trott commented Aug 26, 2018

Nit on the commit message: First word after the subsystem is supposed to be an imperative verb. So maybe test: make http2-large-file test more robust or something like that?

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the ECONNRESET a bug in the http2 implementation? You shouldn't have to do it this way, should you? If so, then the example code in our HTTP/2 docs needs to be updated.

@Trott
Copy link
Member

Trott commented Aug 26, 2018

(Example code that does it the way it is in this test:https://nodejs.org/api/http2.html#http2_clienthttp2session_request_headers_options)

@jasnell
Copy link
Member

jasnell commented Aug 27, 2018

Isn't the ECONNRESET a bug in the http2 implementation? You shouldn't have to do it this way, should you?

This is on my list of things to investigate later on today. Waiting to write shouldn't be necessary.

@BridgeAR
Copy link
Member Author

Going to close this due to the mentioned points.

@BridgeAR BridgeAR closed this Aug 29, 2018
@BridgeAR BridgeAR deleted the make-http2-test-robust branch January 20, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-http2-large-file
4 participants