Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: return if not _connecting #2251

Merged
merged 1 commit into from
Jul 27, 2015
Merged

net: return if not _connecting #2251

merged 1 commit into from
Jul 27, 2015
+10 −1

Commits on Jul 27, 2015

  1. net: don't throw on immediately destroyed socket 

    Fixes regression introduced in af249fa.

With connect being deferred to the next tick, Socket.destroy could be
called before connect. Socket.destroy sets _connecting to false which
would cause an assertion error.

Fixes: nodejs#2250
PR-URL: nodejs#2251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @evanlucas
    evanlucas committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    503b089 View commit details
    Browse the repository at this point in the history