Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: allow typed arrays in .write() #22428

Closed
wants to merge 9 commits into from
Closed

net: allow typed arrays in .write() #22428

wants to merge 9 commits into from

Conversation

SirR4T
Copy link
Contributor

@SirR4T SirR4T commented Aug 21, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Blocked on #22427 , for typed array support in streams.
Partially fixing #1826

@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Aug 21, 2018
@SirR4T SirR4T changed the title net: allow typed arrays net: allow typed arrays in .write() Aug 21, 2018
@BridgeAR BridgeAR added the blocked PRs that are blocked by other issues or PRs. label Aug 21, 2018
@TimothyGu TimothyGu mentioned this pull request Aug 28, 2018
Closed
@SirR4T
Copy link
Contributor Author

SirR4T commented Aug 29, 2018 •
edited
Loading

Rebased against my feature branch from #22427, as that PR seems good to go (green).

Please do not remove the blocked label until that PR is merged to master.

@fhinkel
Copy link
Member

fhinkel commented Oct 26, 2019

Ping @SirR4T Any updates on this?

@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:20
@SirR4T SirR4T requested a review from a team as a code owner August 10, 2020 16:08
@SirR4T SirR4T requested a review from a team August 10, 2020 16:08
@gireeshpunathil
Copy link
Member

@SirR4T - this needs a rebase

@bnb
Copy link
Contributor

bnb commented Jan 7, 2022

Given that the PR this PR depended on was closed without merging for lack of activity and this PR hasn't had activity in about a year, I'm going to close it. Feel free to poke to have it reopened if you've got time @SirR4T :)

@bnb bnb closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SirR4T @fhinkel @gireeshpunathil @bnb @jasnell @BridgeAR @nodejs-github-bot