Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test unknown credential error of process.setgroups #22368

Closed
wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Aug 17, 2018

Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase
coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 17, 2018
@BridgeAR
Copy link
Member

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 17, 2018
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the last CI run didn't go well (infrastructure issues).

@joyeecheung
Copy link
Member

This PR needs a rebase against master to avoid the git failure in the CI.

Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase
coverage.
@shisama shisama force-pushed the test-process-setgroups-error branch from 5f55a29 to 92c29f2 Compare August 20, 2018 01:20
@shisama
Copy link
Contributor Author

shisama commented Aug 20, 2018

@joyeecheung Thank you for your comment. I rebased this.

@joyeecheung
Copy link
Member

@shisama
Copy link
Contributor Author

shisama commented Aug 20, 2018

Maybe node-test-commit-linux failure is a flaky test (#20628).

12:21:48 not ok 2287 sequential/test-http2-session-timeout
12:21:48   ---
12:21:48   duration_ms: 0.926
12:21:48   severity: fail
12:21:48   exitcode: 1
12:21:48   stack: |-
12:21:48     (node:19667) ExperimentalWarning: The http2 module is an experimental API.
12:21:48     assert.js:84
12:21:48       throw new AssertionError(obj);
12:21:48       ^
12:21:48     
12:21:48     AssertionError [ERR_ASSERTION]: function should not have been called at /home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1404-64/test/sequential/test-http2-session-timeout.js:9
12:21:48         at Http2Server.mustNotCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1404-64/test/common/index.js:517:12)
12:21:48         at Http2Server.emit (events.js:182:13)
12:21:48         at ServerHttp2Session.sessionOnTimeout (internal/http2/core.js:2545:15)
12:21:48         at Object.onceWrapper (events.js:273:13)
12:21:48         at ServerHttp2Session.emit (events.js:182:13)
12:21:48         at ServerHttp2Session._onTimeout (internal/http2/core.js:1270:10)
12:21:48         at ontimeout (timers.js:454:11)
12:21:48         at tryOnTimeout (timers.js:326:5)
12:21:48         at listOnTimeout (timers.js:300:5)
12:21:48         at processTimers (timers.js:257:5)

@addaleax
Copy link
Member

@addaleax
Copy link
Member

Landed in 4dc8467 🎉

@addaleax addaleax closed this Aug 24, 2018
addaleax pushed a commit that referenced this pull request Aug 24, 2018
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to
increase coverage.

PR-URL: #22368
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Aug 24, 2018
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to
increase coverage.

PR-URL: #22368
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Sep 3, 2018
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to
increase coverage.

PR-URL: #22368
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants