test: remove redundant cli tests #22355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16479/ (EDIT:) New CI after removing the second test file: https://ci.nodejs.org/job/node-test-pull-request/16481/ ✔️ |
bengl
changed the title
BridgeAR
approved these changes
Aug 16, 2018
jasnell
approved these changes
Aug 16, 2018
|
/cc @nodejs/testing |
lpinca
approved these changes
Aug 16, 2018
BridgeAR
added
the
author ready
trivikr
approved these changes
Aug 17, 2018
tniessen
approved these changes
Aug 18, 2018
gdams
approved these changes
Aug 21, 2018
test/parallel/test-cli-eval.js covers them, and many more things.
|
CI after rebasing: https://ci.nodejs.org/job/node-test-pull-request/16669/ |
|
Landed in 6acb550 |
gdams
approved these changes
Aug 22, 2018
bengl
added a commit
that referenced
this pull request
Aug 22, 2018
test/parallel/test-cli-eval.js covers them, and many more things. PR-URL: #22355 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
test/parallel/test-cli-eval.js covers them, and many more things. PR-URL: #22355 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
test/parallel/test-cli-eval.js covers them, and many more things. PR-URL: #22355 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/parallel/test-cli-eval.jscovers it, and many more things.Note: I know test redundancy can generally be a good thing, but when I came across
test/parallel/test-eval.js, it appeared to me that this was the only test for cli eval. Removing this redundant (and incomplete) test reduces the chances of such confusion in the future. In addition, I'm not sure that redundant tests that simply do exactly the same thing as another test are necessarily useful. (EDIT: On further inspection, I also found thattest/parallel/test-eval-require.jsis similarly redundant, so this is now removed as well.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes