Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: unmark tests as flaky #22253

Merged
merged 0 commits into from
Aug 13, 2018
Merged

inspector: unmark tests as flaky #22253

merged 0 commits into from
Aug 13, 2018

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 10, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

No failures across 1000 runs (red bots seem to be unsupported): https://ci.nodejs.org/job/node-stress-single-test/1979/

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 10, 2018
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@Trott
Copy link
Member

Trott commented Aug 11, 2018

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol labels Aug 11, 2018
@trivikr
Copy link
Member

trivikr commented Aug 12, 2018

@eugeneo eugeneo closed this Aug 13, 2018
@eugeneo eugeneo deleted the tests_not_flaky branch August 13, 2018 16:24
@eugeneo eugeneo merged commit 2eb78e6 into nodejs:master Aug 13, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
PR-URL: #22253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.