Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused env strings #22137

Closed
wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

user_string: Usage removed in 4e05952
onstop_string: Usage removed in 7b46e17
max_old_space_size_string: Added in 0df031a, never used
max_semi_space_size_string: Added in 0df031a, never used
enter_string: Usage removed in eeede3b

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

user_string: Usage removed in 4e05952
onstop_string: Usage removed in 7b46e17
max_old_space_size_string: Added in 0df031a, never used
max_semi_space_size_string: Added in 0df031a, never used
enter_string: Usage removed in eeede3b
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 5, 2018
@tniessen
Copy link
Member

tniessen commented Aug 5, 2018

Please 👍 here if you approve fast-tracking.

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 5, 2018
@tniessen
Copy link
Member

tniessen commented Aug 5, 2018

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 5, 2018
tniessen pushed a commit that referenced this pull request Aug 5, 2018
user_string:
Usage removed in 4e05952
onstop_string:
Usage removed in 7b46e17
max_old_space_size_string:
Added in 0df031a, never used
max_semi_space_size_string:
Added in 0df031a, never used
enter_string:
Usage removed in eeede3b

PR-URL: #22137
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen
Copy link
Member

tniessen commented Aug 5, 2018

Fast-tracking has been approved by @tniessen, @addaleax and @targos. Landed in 2519dcc.

@tniessen tniessen closed this Aug 5, 2018
@maclover7 maclover7 deleted the jm-rm-strings branch August 5, 2018 20:13
targos pushed a commit that referenced this pull request Aug 6, 2018
user_string:
Usage removed in 4e05952
onstop_string:
Usage removed in 7b46e17
max_old_space_size_string:
Added in 0df031a, never used
max_semi_space_size_string:
Added in 0df031a, never used
enter_string:
Usage removed in eeede3b

PR-URL: #22137
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants