Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove third argument from call to assert.strictEqual() #22047

Closed
wants to merge 1 commit into from
Closed

test: remove third argument from call to assert.strictEqual() #22047

wants to merge 1 commit into from

Conversation

mpsommer
Copy link
Contributor

Removed the third argument from call to assert.strictEqual because it prevents the value of sha1Hash.digest('hex') from being displayed if an AssertionError occurs. The third argument is retained as a comment.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 31, 2018
@Trott
Copy link
Member

Trott commented Aug 1, 2018

@Trott
Copy link
Member

Trott commented Aug 1, 2018

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 2, 2018
@Trott
Copy link
Member

Trott commented Aug 2, 2018

+1 to fast-tracking.

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 2, 2018
PR-URL: nodejs#22047
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Aug 2, 2018

Landed in 1f56c56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants