Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: make own properties shadow prototype properties #21588

Closed
wants to merge 1 commit into from
Closed

repl: make own properties shadow prototype properties #21588

wants to merge 1 commit into from

Commits on Jun 29, 2018

  1. repl: make own properties shadow prototype properties 

    Previously, the code displayed properties backwards (e.g., showing prototype
properties before own properties).  It also did uniqueness checks during this
processing, so these checks were done backwards.

After this change, the properties continue to be displayed backwards, but
the uniqueness checks are done in the proper order.

Fixes: nodejs#15199

See also: nodejs#21586 which was discovered
during the testing of this fix.
    @rubys
    rubys committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    d4d9b20 View commit details
    Browse the repository at this point in the history