build: avoid calling configure twice from vcbuild #2128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in a merge from nodejs (dcbb9e1).
|
The final step after merging this PR would be removing the jenkins configure step alternatively passing |
|
@jbergstroem I think there might still be some issues. I opened #2131 because it's probably faster than iterating over this PR. |
| @@ -86,19 +86,12 @@ if "%i18n_arg%"=="intl-none" set i18n_arg=--with-intl=none | |||
|
|
|||
| call :getnodeversion || exit /b 1 | |||
|
|
|||
| @rem Set environment for msbuild | |||
| :project-gen | |||
| @rem Skip project generation if requested. | |||
| if defined noprojgen goto msbuild | |||
There was a problem hiding this comment.
We still need to set the environment even if we skip project generation
|
Closed in favour of #2131. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in a merge from nodejs (dcbb9e1).
/R= @nodejs/build