test: add test cases for validateOffsetLengthWrite. #21195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzokuken
approved these changes
Jun 7, 2018
iwko
approved these changes
Jun 7, 2018
trivikr
approved these changes
Jun 8, 2018
jasnell
reviewed
Jun 10, 2018
| @@ -0,0 +1,56 @@ | |||
| // Flags: --expose-internals | |||
|
|
|||
There was a problem hiding this comment.
nit: unnecessary blank line here
There was a problem hiding this comment.
Thanks! I'll delete it.
jasnell
approved these changes
Jun 10, 2018
|
Hi, I've already fixed it. Please review it again. |
apapirovski
approved these changes
Jun 25, 2018
apapirovski
added
the
author ready
|
Landed in a9d9d76 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jun 26, 2018
PR-URL: #21195 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos
pushed a commit
that referenced
this pull request
Jun 28, 2018
PR-URL: #21195 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary.
Added some test cases for validateOffsetLengthWrite in lib/internal/utils.js
This PR improves the test coverage of it.
https://coverage.nodejs.org/coverage-75e91659887012f7/root/internal/fs/utils.js.html#L301
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes