Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: promises fixes #20407

Merged
merged 2 commits into from
May 8, 2018
Merged

fs: promises fixes #20407

merged 2 commits into from
May 8, 2018

Commits on May 8, 2018

  1. fs: remove broken code in promises/write 

    That code expects the last argument to be a callback.
When it's not a callback, it shifts arguments, defaulting
encoding to 'utf-8', which is clearly broken.

Old signature: (fd, string[, position[, encoding]], callback)
New signature: (fd, string[, position[, encoding]])

PR-URL: nodejs#20407
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jamie Davis <davisjam@vt.edu>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @ChALkeR
    ChALkeR committed May 8, 2018
    Configuration menu
    Copy the full SHA
    ca6b12e View commit details
    Browse the repository at this point in the history

  2. fs: fchmod->fchown in promises/lchown 

    This was a clear error.

chown should do chown, not chmod.

PR-URL: nodejs#20407
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jamie Davis <davisjam@vt.edu>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @ChALkeR
    ChALkeR committed May 8, 2018
    Configuration menu
    Copy the full SHA
    15f7431 View commit details
    Browse the repository at this point in the history