Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: copy all openssl header files to include dir #2016

Closed
wants to merge 1 commit into from
Closed

deps: copy all openssl header files to include dir #2016

wants to merge 1 commit into from

Conversation

shigeki
Copy link
Contributor

@shigeki shigeki commented Jun 19, 2015

On upgrading openssl, all symlinks in pulic header files are replaced with nested include files. The issue was raised that installing them leads to lost its references to real header files.
To avoid this, all public header files are copied into the deps/openssl/openssl/include/openssl/ directory.
As a result, we have duplicated header files under deps/openssl/openssl/ but copied files are refereed in build as specified to include path in openssl.gyp.

Fixes: #1975

R= @indutny @rvagg

deps: copy all openssl header files to include dir
618f283 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: nodejs#1975
@shigeki
Copy link
Contributor Author

shigeki commented Jun 19, 2015

CI of https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/55/ is fine except one failure on Win that was timing issue.

@brendanashworth brendanashworth added the openssl Issues and PRs related to the OpenSSL dependency. label Jun 19, 2015
@rvagg
Copy link
Member

rvagg commented Jun 19, 2015

yep, they look good when this is applied on top of my headers tarball PR and I make a tarball so lgtm

/cc @nodejs/build

@shigeki shigeki mentioned this pull request Jun 25, 2015
Closed
@jbergstroem
Copy link
Member

LGTM. Lets land this before #1975.

@jbergstroem jbergstroem mentioned this pull request Jun 25, 2015
Merged
shigeki pushed a commit that referenced this pull request Jun 25, 2015
deps: copy all openssl header files to include dir
09b2cf4 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: #1975
PR-URL: #2016
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu>
@shigeki
Copy link
Contributor Author

shigeki commented Jun 25, 2015

Thanks. Landed in 09b2cf4 .

@shigeki shigeki closed this Jun 25, 2015
shigeki pushed a commit that referenced this pull request Jun 25, 2015
@rvagg
deps: copy all openssl header files to include dir
1f371e3 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: #1975
PR-URL: #2016
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvagg pushed a commit to rvagg/io.js that referenced this pull request Jun 25, 2015
@rvagg
deps: copy all openssl header files to include dir
650c8de 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: nodejs#1975
PR-URL: nodejs#2016
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
shigeki pushed a commit that referenced this pull request Jun 26, 2015
@rvagg
deps: copy all openssl header files to include dir
91392fc 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: #1975
PR-URL: #2016
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This was referenced Jun 27, 2015
Closed
Closed
rvagg pushed a commit to rvagg/io.js that referenced this pull request Jul 3, 2015
@rvagg
deps: copy all openssl header files to include dir
ec8d4ba 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: nodejs#1975
PR-URL: nodejs#2016
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
shigeki pushed a commit that referenced this pull request Jul 3, 2015
@Fishrock123
deps: copy all openssl header files to include dir
83ee07b 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: #1975
PR-URL: #2016
PORT-PR-URL: #2101
PORT-FROM: 1f371e3
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
@mscdex
deps: copy all openssl header files to include dir
51bdf8c 
On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: nodejs#1975
PR-URL: nodejs#2016
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@MylesBorins MylesBorins mentioned this pull request Feb 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shigeki @rvagg @jbergstroem @brendanashworth