[v9.x] net: handle allowHalfOpen before calling super ctor #19772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 152c931.
This reverts commit 5b12d3a.
If the `allowHalfOpen` option is not provided, use its default value before calling the `Duplex` constructor. This allows the no-half-open enforcer to be properly added. Fixes: nodejs#19764
nodejs-github-bot
added
build
|
I would prefer not to land this as the change in behavior described in #19764 is actually a bug fix. If the only affected module is |
|
@nodejs/collaborators @nodejs/lts before I rebase, what do you think? See also #19764. |
|
Should I close this and mark the original issue as won't fix? |
@lpinca Given that there hasn't been any activity around this for a month, it probably won't do any harm to do so. |
|
Ok, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
allowHalfOpenoption is not provided, use its default valuebefore calling the
Duplexconstructor. This allows the no-half-openenforcer to be properly added.
Fixes: #19764
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes