Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fixing isStackOverflowError to account for different JS engines #19705

Closed
wants to merge 3 commits into from
Closed

lib: fixing isStackOverflowError to account for different JS engines #19705

wants to merge 3 commits into from

Commits on Mar 30, 2018

  1. lib: fixing isStackOverflowError to account for different JS engines 

    Assumption that stack overflow exception has name == "RangeError" is
v8-specific.  Updated logic to dynamically capture error name when
capturing error message.
    Mike Kaufman committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    01b9afb View commit details
    Browse the repository at this point in the history

  2. fixup! lib: fixing isStackOverflowError to account for different JS e… 

    …ngines

Remove extraneous space.
    @TimothyGu
    TimothyGu committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    2b4118c View commit details
    Browse the repository at this point in the history

  3. responding to PR feedback

    Mike Kaufman committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    d6267a8 View commit details
    Browse the repository at this point in the history