Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: dry utility function in tools/doc/json.js #19692

Closed
wants to merge 1 commit into from
Closed

tools: dry utility function in tools/doc/json.js #19692

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Also, move a declaration of unrelated variable closer to its only context.

Generated doc set is identical after this change.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 30, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 30, 2018
@vsemozhetbyt
Copy link
Contributor Author

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2018
Also, move a declaration of unrelated variable
closer to its only context.
@vsemozhetbyt
Copy link
Contributor Author

Rebased after the #19696

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/368/

@vsemozhetbyt
Copy link
Contributor Author

Landed in 83d44be

@vsemozhetbyt vsemozhetbyt deleted the tools-doc-json-dry branch March 30, 2018 13:35
vsemozhetbyt added a commit that referenced this pull request Mar 30, 2018
Also, move a declaration of unrelated variable
closer to its only context.

PR-URL: #19692
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Apr 2, 2018
Also, move a declaration of unrelated variable
closer to its only context.

PR-URL: #19692
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Apr 4, 2018
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
Also, move a declaration of unrelated variable
closer to its only context.

PR-URL: #19692
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants