buffer: remove "new" from deprecation message #19687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes "new" as a description for `Buffer` construction methods. They are arguably not "new" anymore and they certainly won't be "new" anymore at some point.
nodejs-github-bot
added
the
buffer
lpinca
approved these changes
Mar 30, 2018
Trott
added
the
author ready
targos
approved these changes
Mar 30, 2018
TimothyGu
approved these changes
Mar 30, 2018
Adsada2205
approved these changes
Mar 30, 2018
ChALkeR
approved these changes
Mar 30, 2018
trivikr
approved these changes
Mar 30, 2018
seishun
approved these changes
Mar 30, 2018
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
approved these changes
Mar 30, 2018
cjihrig
approved these changes
Mar 30, 2018
jasnell
approved these changes
Apr 1, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 2, 2018
This change removes "new" as a description for `Buffer` construction methods. They are arguably not "new" anymore and they certainly won't be "new" anymore at some point. PR-URL: nodejs#19687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 87972cd |
2 tasks
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 2, 2018
Shorten the deprecation warning for Buffer constructor. Ref: nodejs#19687 (review)
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
This change removes "new" as a description for `Buffer` construction methods. They are arguably not "new" anymore and they certainly won't be "new" anymore at some point. PR-URL: #19687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes "new" as a description for
Bufferconstructionmethods. They are arguably not "new" anymore and they certainly won't be
"new" anymore at some point.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes