Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: ICU 61.1 bump #19621

Merged
merged 0 commits into from
Apr 3, 2018
Merged

deps: ICU 61.1 bump #19621

merged 0 commits into from
Apr 3, 2018

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 26, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Mar 26, 2018
@srl295 srl295 self-assigned this Mar 26, 2018
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Mar 26, 2018
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM

@srl295
Copy link
Member Author

srl295 commented Apr 2, 2018

@srl295
Copy link
Member Author

srl295 commented Apr 3, 2018

ooh, almost forgot:

  • bump icu4c-data npms to support this version…

@srl295 srl295 closed this Apr 3, 2018
@srl295 srl295 merged commit 6421140 into nodejs:master Apr 3, 2018
@srl295 srl295 deleted the icu4c-61.1 branch April 3, 2018 01:19
targos pushed a commit that referenced this pull request Apr 3, 2018
- Update to released ICU 61.1, including:
  - CLDR 33 (many new languages and data improvements)
  - Many small API additions, improvements, and bug fixes
  - note: 'icu::' namespace is no longer used by default
   (Necessated #18667 )

PR-URL: #19621
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Apr 4, 2018
Notable changes:

* deps:
  - Updated ICU to 61.1 (Steven R. Loomis)
    [#19621](#19621)
    Includes CLDR 33 (many new languages and data improvements).
* fs:
  - Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer
    Srivastava) [#19408](#19408)
* n-api:
  - Bump version of n-api supported (Michael Dawson)
    [#19497](#19497)
* net:
  - Emit 'ready' event for `Socket` (Sameer Srivastava)
    [#19408](#19408)
* Added new collaborators
  - [mafintosh](https://github.com/mafintosh) Mathias Buus
@targos targos mentioned this pull request Apr 4, 2018
MylesBorins pushed a commit that referenced this pull request Apr 4, 2018
Notable changes:

* deps:
  - Updated ICU to 61.1 (Steven R. Loomis)
    [#19621](#19621)
    Includes CLDR 33 (many new languages and data improvements).
* fs:
  - Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer
    Srivastava) [#19408](#19408)
* n-api:
  - Bump version of n-api supported (Michael Dawson)
    [#19497](#19497)
* net:
  - Emit 'ready' event for `Socket` (Sameer Srivastava)
    [#19408](#19408)
* Added new collaborators
  - [mafintosh](https://github.com/mafintosh) Mathias Buus
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants