Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add 'v' prefix to all versions in metadata #19590

Closed
wants to merge 1 commit into from
Closed

doc: add 'v' prefix to all versions in metadata #19590

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Change version literals for consistency with the rest (9 vs 1661 occurrences).

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 25, 2018
@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/329/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 25, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Mar 25, 2018 •
edited
Loading

New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/330/

(something happens to CI-lite, it gets aborted too often lately)

@vsemozhetbyt
Copy link
Contributor

Heh. Again: https://ci.nodejs.org/job/node-test-pull-request-lite/331/

@vsemozhetbyt
Copy link
Contributor

I give up)

@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

CI-lite which didn't abort 😉https://ci.nodejs.org/job/node-test-pull-request-lite/334/

@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

Landed in e821071

@trivikr trivikr closed this Mar 25, 2018
trivikr pushed a commit that referenced this pull request Mar 25, 2018
@tniessen @trivikr
doc: add 'v' prefix to all versions in metadata
e821071 
PR-URL: #19590
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2018
@tniessen @targos
doc: add 'v' prefix to all versions in metadata
f07e820 
PR-URL: #19590
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@tniessen tniessen removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @vsemozhetbyt @trivikr @targos @cjihrig @richardlau @BridgeAR @nodejs-github-bot