Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing fs.Stats.size section #19583

Closed
wants to merge 1 commit into from
Closed

doc: add missing fs.Stats.size section #19583

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 25, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 25, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 25, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/321/

trivikr
trivikr approved these changes Mar 25, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that size is a number from TS definitions https://github.com/DefinitelyTyped/DefinitelyTyped/blob/2e3cfeee51f0fcf6efda97c9453aa4946ae77fca/types/node/index.d.ts#L2946

vsemozhetbyt added a commit that referenced this pull request Mar 26, 2018
@vsemozhetbyt
doc: add missing fs.Stats.size section
eac4c65 
PR-URL: #19583
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in eac4c65

@vsemozhetbyt vsemozhetbyt deleted the fs-stat-size branch March 26, 2018 18:23
targos pushed a commit that referenced this pull request Mar 27, 2018
@vsemozhetbyt @targos
doc: add missing fs.Stats.size section
5a2f336 
PR-URL: #19583
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leko Leko Leko approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @Leko @trivikr @nodejs-github-bot