src: name all builtin init functions Initialize #19550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames a few of the builtin modules init functions to Initialize for consistency.
nodejs-github-bot
added
c++
node-test-commit-arm-fanned failure looks unrelated07:10:23 not ok 207 parallel/test-stdio-pipe-redirect
07:10:23 ---
07:10:23 duration_ms: 7.871
07:10:23 severity: fail
07:10:23 stack: |-
07:10:23 pure virtual method called
07:10:23 terminate called without an active exception |
addaleax
approved these changes
Mar 23, 2018
TimothyGu
approved these changes
Mar 24, 2018
jasnell
approved these changes
Mar 24, 2018
|
Landed in ebbf393. |
danbev
added a commit
that referenced
this pull request
Mar 26, 2018
This commit renames a few of the builtin modules init functions to Initialize for consistency. PR-URL: #19550 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
This commit renames a few of the builtin modules init functions to Initialize for consistency. PR-URL: #19550 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames a few of the builtin modules init functions to
Initialize for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes