Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct introduced_in metadata for buffer doc #19545

Closed
wants to merge 1 commit into from
Closed

doc: correct introduced_in metadata for buffer doc #19545

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 23, 2018

The buffer module was introduced in v0.1.90. Updated introduced_in
value in buffer.md to reflect this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: correct introduced_in metadata for buffer doc
206cb60 
The buffer module was introduced in v0.1.90. Updated `introduced_in`
value in `buffer.md` to reflect this.
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Mar 23, 2018
@Trott
Copy link
Member Author

Trott commented Mar 23, 2018 •
edited
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/300/

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 23, 2018
@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2018
trivikr
trivikr approved these changes Mar 24, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that buffer module was introduced in v0.1.90 from commit 025116f

@trivikr
Copy link
Member

trivikr commented Mar 24, 2018

Landed in 2289267

@trivikr trivikr closed this Mar 24, 2018
trivikr pushed a commit that referenced this pull request Mar 24, 2018
@Trott @trivikr
doc: correct introduced_in metadata for buffer doc
2289267 
The buffer module was introduced in v0.1.90. Updated `introduced_in`
value in `buffer.md` to reflect this.

PR-URL: #19545
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
@Trott @targos
doc: correct introduced_in metadata for buffer doc
7c9ba3d 
The buffer module was introduced in v0.1.90. Updated `introduced_in`
value in `buffer.md` to reflect this.

PR-URL: #19545
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott Trott deleted the 0.1.90 branch October 15, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @trivikr @lpinca @cjihrig @vsemozhetbyt @tniessen @nodejs-github-bot