tools: make some changes to .editorconfig #19521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The src directory does not contain any JavaScript files, so there is no need to match it.
Leko
approved these changes
Mar 26, 2018
gibfahn
approved these changes
Mar 27, 2018
|
I think @Fishrock123 may have been a user of this file |
tniessen
added a commit
that referenced
this pull request
Apr 1, 2018
The src directory does not contain any JavaScript files, so there is no need to match it. PR-URL: #19521 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
tniessen
added a commit
that referenced
this pull request
Apr 1, 2018
PR-URL: #19521 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
The src directory does not contain any JavaScript files, so there is no need to match it. PR-URL: #19521 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
PR-URL: #19521 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
The src directory does not contain any JavaScript files, so there is no need to match it. PR-URL: #19521 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
PR-URL: #19521 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srcdirectory does not contain any JavaScript source files, so there is no need to include the directory in the rule definition.toolsdirectory contains JavaScript files which should be matched, most importantlytools/eslint-rulesandtools/doc.One side-effect of the second change is that the following rules now apply to some other files in the
toolsdirectory which were previously ignored:Will this cause problems for anyone?
Checklist