Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix tab completion of inspector module #19505

Closed
wants to merge 1 commit into from
Closed

repl: fix tab completion of inspector module #19505

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 21, 2018

Correctly check for the presence of the inspector module before adding
it to the builtin libs list.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@targos
repl: fix tab completion of inspector module
e4b4855 
Correctly check for the presence of the inspector module before adding
it to the builtin libs list.
@targos targos added the repl Issues and PRs related to the REPL subsystem. label Mar 21, 2018
@hiroppy
Copy link
Member

hiroppy commented Mar 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13809/

@targos
Copy link
Member Author

targos commented Mar 23, 2018

Rebuild plinux: https://ci.nodejs.org/job/node-test-commit-plinux/16264/

@targos
Copy link
Member Author

targos commented Mar 23, 2018

Landed in a6f3e8f

@targos targos closed this Mar 23, 2018
@targos targos deleted the fix-builtin-libs branch March 23, 2018 07:55
targos added a commit that referenced this pull request Mar 23, 2018
@targos
repl: fix tab completion of inspector module
a6f3e8f 
Correctly check for the presence of the inspector module before adding
it to the builtin libs list.

PR-URL: #19505
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Mar 30, 2018
@targos
repl: fix tab completion of inspector module
ee4390a 
Correctly check for the presence of the inspector module before adding
it to the builtin libs list.

PR-URL: #19505
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @hiroppy @jasnell @lpinca @TimothyGu @cjihrig