Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: eliminate unnecessary nextTicks, use stream close event #19451

Closed
wants to merge 2 commits into from
Closed

http2: eliminate unnecessary nextTicks, use stream close event #19451

wants to merge 2 commits into from

Commits on Mar 19, 2018

  1. http2: remove some unnecessary next ticks

    @jasnell
    jasnell committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    d3b9090 View commit details
    Browse the repository at this point in the history

  2. http2: do not emit our own close emit in Http2Stream 

    Streams were recently updated to emit their own close event. The
Http2Stream was an exception because it included the close argument
with the close event. Refactor that to use the built in close.
    @jasnell
    jasnell committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    744b268 View commit details
    Browse the repository at this point in the history