Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add trivikr to collaborators #19384

Closed
wants to merge 1 commit into from
Closed

doc: add trivikr to collaborators #19384

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 16, 2018 •
edited
Loading

trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: #19067

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 16, 2018
fhinkel
fhinkel approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

XadillaX
XadillaX approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Trott
Copy link
Member

Trott commented Mar 17, 2018 •
edited
Loading

Looks like maybe this was done without someone actually doing the onboarding? I don't see @trivikr in the right GitHub team so they can't start CI and they can't land this PR.

Anyone on @nodejs/tsc available to do an onboarding session with them? Maybe @mcollina as they nominated @trivikr? I'm not available until the middle of next week, but can do it after that if no one else steps up.

richardlau
richardlau requested changes Mar 17, 2018
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs in commit message should be #19067

@mcollina
Copy link
Member

I’m available all of next week. I’ll ping @trivikr via email.

@trivikr
doc: add trivikr to collaborators
e6a3436 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: nodejs#19067
@trivikr
Copy link
Member Author

trivikr commented Mar 17, 2018

Thanks @richardlau for the catch!
I've updated Refs to #19067

@trivikr trivikr mentioned this pull request Mar 19, 2018
Closed
@trivikr
Copy link
Member Author

trivikr commented Mar 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/279/

@trivikr
Copy link
Member Author

trivikr commented Mar 20, 2018

Landed in 6a958d2

@trivikr trivikr closed this Mar 20, 2018
trivikr added a commit that referenced this pull request Mar 20, 2018
@trivikr
doc: add trivikr to collaborators
6a958d2 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: #19067

PR-URL: #19384
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@trivikr trivikr deleted the add-trivikr-collab branch March 20, 2018 15:49
@targos
Copy link
Member

targos commented Mar 20, 2018

Welcome!

MylesBorins pushed a commit that referenced this pull request Mar 22, 2018
@trivikr @MylesBorins
doc: add trivikr to collaborators
9c9263e 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: #19067

PR-URL: #19384
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@trivikr @MylesBorins
doc: add trivikr to collaborators
ab559b8 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: #19067

PR-URL: #19384
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@benjamingr benjamingr benjamingr approved these changes

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@XadillaX XadillaX XadillaX approved these changes

@mmarchini mmarchini mmarchini approved these changes

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.