Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http2-settings-flood #19349

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-http2-settings-flood #19349

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 14, 2018

The test is unreliable on some Windows platforms in its current form.
Make it more robust by using setInterval() to repeat the flooding
until an error is triggered.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Mar 14, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 14, 2018
@Trott
Copy link
Member Author

Trott commented Mar 14, 2018

Marking as in progress until I can determine that this actually fixes the issue....

@Trott
Copy link
Member Author

Trott commented Mar 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13679/

@Trott Trott mentioned this pull request Mar 14, 2018
Closed
@Trott Trott force-pushed the unflake branch 2 times, most recently from d35d667 to 38db513 Compare March 14, 2018 21:26
@Trott
Copy link
Member Author

Trott commented Mar 14, 2018

The change "worked" in that the test kept trying but it got ECONNRESET before the flood error. Trying again but swallowing ECONNRESET errors. Really, though, thing to do is probably make the flooding threshold configurable (if it is not) and then reduce it to something really low for this test...

@Trott
Copy link
Member Author

Trott commented Mar 14, 2018

CI: https://ci.nodejs.org/job/node-test-commit/16923/

Well, in that case, it just times out....

@Trott
Copy link
Member Author

Trott commented Mar 14, 2018

One option is to skip the test if ECONNRESET is received, but that may be even worse than the current situation, which unfortunately is that if the test fails, we shrug it off because the test is inherently unreliable.

@Trott
Copy link
Member Author

Trott commented Mar 15, 2018

OMG, doing it in 10K chunks appears to have fixed the problem on Windows! Removing in progress.

CI: https://ci.nodejs.org/job/node-test-pull-request/13689/ (Failure on LinuxONE appears build related and unrelated to this change. Re-run: https://ci.nodejs.org/job/node-test-commit-linuxone/13659/ )

@Trott Trott removed the wip Issues and PRs that are still a work in progress. label Mar 15, 2018
@Trott
test: fix flaky test-http2-settings-flood
6dec0e1 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: nodejs#18251
@Trott
Copy link
Member Author

Trott commented Mar 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13693/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2018
apapirovski
apapirovski approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@Trott
Copy link
Member Author

Trott commented Mar 16, 2018

Landed in 879f521

@Trott Trott closed this Mar 16, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 16, 2018
@Trott
test: fix flaky test-http2-settings-flood
879f521 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: nodejs#18251

PR-URL: nodejs#19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit that referenced this pull request Mar 17, 2018
@Trott @targos
test: fix flaky test-http2-settings-flood
425c589 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott @MylesBorins
test: fix flaky test-http2-settings-flood
739caeb 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott @MylesBorins
test: fix flaky test-http2-settings-flood
01749f0 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
codebytere pushed a commit that referenced this pull request Oct 18, 2018
@Trott @codebytere
test: fix flaky test-http2-settings-flood
b407060 
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using `setInterval()` to repeat the flooding
until an error is triggered.

Fixes: #18251

PR-URL: #19349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
@mcollina mcollina mentioned this pull request Dec 14, 2018
Closed
@Trott Trott deleted the unflake branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @apapirovski @jasnell @codebytere @tniessen @nodejs-github-bot