src: refactor emit before/after/promiseResolve #19295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently EmitBefore, EmitAfter, EmitPromiseResolve are very similar. This commit suggests extracting the code they have in common to a new function to reduce code duplication.
nodejs-github-bot
added
the
c++
node-test-commit failure looks unrelated06:10:11 Makefile:475: recipe for target 'run-ci' failed
06:10:11 make: *** [run-ci] Error 2
06:10:11 Build step 'Execute shell' marked build as failure
06:10:11 Run condition [Always] enabling perform for step [[]]
06:10:11 Run condition [Always] enabling perform for step [[]]
06:10:11 TAP Reports Processing: START
06:10:11 Looking for TAP results report in workspace using pattern: *.tap
06:10:11 Did not find any matching files. Setting build result to FAILURE.
06:10:11 Checking ^not ok
06:10:11 Jenkins Text Finder: File set '*.tap' is empty
06:10:11 Notifying upstream projects of job completion
06:10:11 Finished: FAILURE |
jasnell
reviewed
Mar 12, 2018
| @@ -162,19 +162,25 @@ static void DestroyAsyncIdsCallback(void* arg) { | |||
| } | |||
|
|
|||
|
|
|||
| void AsyncWrap::EmitPromiseResolve(Environment* env, double async_id) { | |||
| void Emit(Environment* env, double async_id, AsyncHooks::Fields type, | |||
There was a problem hiding this comment.
@jasnell Imo we shouldn’t be adding inline to functions that aren’t defined in the corresponding -inl.h header
Also, @bnoordhuis pointed out somewhere else that we should put the inline specifier on the declarations in the .h header file
addaleax
approved these changes
Mar 12, 2018
|
Landed in 861285a. |
danbev
added a commit
that referenced
this pull request
Mar 14, 2018
Currently EmitBefore, EmitAfter, EmitPromiseResolve are very similar. This commit suggests extracting the code they have in common to a new function to reduce code duplication. PR-URL: #19295 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
Currently EmitBefore, EmitAfter, EmitPromiseResolve are very similar. This commit suggests extracting the code they have in common to a new function to reduce code duplication. PR-URL: #19295 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Currently EmitBefore, EmitAfter, EmitPromiseResolve are very similar. This commit suggests extracting the code they have in common to a new function to reduce code duplication. PR-URL: #19295 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Currently EmitBefore, EmitAfter, EmitPromiseResolve are very similar. This commit suggests extracting the code they have in common to a new function to reduce code duplication. PR-URL: nodejs#19295 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently EmitBefore, EmitAfter, EmitPromiseResolve are very similar.
This commit suggests extracting the code they have in common to a new
function to reduce code duplication.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes