Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix test-npm-package #19293

Closed
wants to merge 1 commit into from
Closed

tools: fix test-npm-package #19293

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 12, 2018

Migrate the script to the new common tmpDir API.

Checklist

@targos
tools: fix test-npm-package
04f2bed 
Migrate the script to the new common tmpDir API.
@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 12, 2018
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 12, 2018
@targos
Copy link
Member Author

targos commented Mar 12, 2018

I'd like to fast-track this to open the PR to update npm.

@targos
Copy link
Member Author

targos commented Mar 12, 2018

CI: https://ci.nodejs.org/view/All/job/node-test-npm/34/node=osx1010/

@targos
Copy link
Member Author

targos commented Mar 12, 2018

Test "passed" (some failures but the script ran without an error).
Anyone, feel free to land this PR, as I won't be able to before tomorrow.

@targos targos mentioned this pull request Mar 12, 2018
Closed
2 tasks
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2018
Closed
4 tasks
MylesBorins
MylesBorins approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 12, 2018
@MylesBorins
Copy link
Contributor

land in 0acdd84

MylesBorins pushed a commit that referenced this pull request Mar 12, 2018
@targos @MylesBorins
tools: fix test-npm-package
0acdd84 
Migrate the script to the new common tmpDir API.

PR-URL: #19293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos added a commit that referenced this pull request Mar 17, 2018
@targos
tools: fix test-npm-package
c61aaad 
Migrate the script to the new common tmpDir API.

PR-URL: #19293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@targos @MylesBorins
tools: fix test-npm-package
66694e2 
Migrate the script to the new common tmpDir API.

PR-URL: #19293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@targos @MayaLekova
tools: fix test-npm-package
3a8dab9 
Migrate the script to the new common tmpDir API.

PR-URL: nodejs#19293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
princjef pushed a commit to princjef/node that referenced this pull request Jun 12, 2018
@targos @princjef
tools: fix test-npm-package
5372a44 
Migrate the script to the new common tmpDir API.

PR-URL: nodejs#19293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@princjef princjef mentioned this pull request Jun 13, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@targos @MylesBorins
tools: fix test-npm-package
d787935 
Migrate the script to the new common tmpDir API.

Backport-PR-URL: #21302
PR-URL: #19293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@targos @rvagg
tools: fix test-npm-package
5362e2f 
Migrate the script to the new common tmpDir API.

Backport-PR-URL: #21302
PR-URL: #19293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos deleted the fix-test-npm branch October 17, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @MylesBorins @jasnell @watilde @cjihrig @richardlau @BridgeAR @joyeecheung @nodejs-github-bot