Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify default TLS handshake timeout #19290

Closed
wants to merge 1 commit into from
Closed

doc: clarify default TLS handshake timeout #19290

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 12, 2018

Because the handshakeTimeout is in milliseconds, use that unit of
measurement to express the default value.

Checklist

@Trott
doc: clarify default TLS handshake timeout
f1bd22a 
Because the `handshakeTimeout` is in milliseconds, use that unit of
measurement to express the default value.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Mar 12, 2018
@Trott
Copy link
Member Author

Trott commented Mar 12, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/251/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 12, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 14, 2018
@Trott
doc: clarify default TLS handshake timeout
14809aa 
Because the `handshakeTimeout` is in milliseconds, use that unit of
measurement to express the default value.

PR-URL: nodejs#19290
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 14, 2018

Landed in 14809aa

@Trott Trott closed this Mar 14, 2018
targos pushed a commit that referenced this pull request Mar 17, 2018
@Trott @targos
doc: clarify default TLS handshake timeout
8d9ac75 
Because the `handshakeTimeout` is in milliseconds, use that unit of
measurement to express the default value.

PR-URL: #19290
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott @MylesBorins
doc: clarify default TLS handshake timeout
5da3ee7 
Because the `handshakeTimeout` is in milliseconds, use that unit of
measurement to express the default value.

PR-URL: #19290
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the s-v-ms branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @cjihrig @BethGriggs @nodejs-github-bot