test: fix assertion argument order #19264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: nodejs#19263
richardlau
approved these changes
Mar 9, 2018
cjihrig
approved these changes
Mar 9, 2018
lpinca
approved these changes
Mar 9, 2018
Trott
added
the
author ready
jasnell
approved these changes
Mar 9, 2018
tniessen
approved these changes
Mar 11, 2018
jasnell
pushed a commit
that referenced
this pull request
Mar 12, 2018
Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in da226ea |
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: nodejs#19263 PR-URL: nodejs#19264 Refs: nodejs#19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 16, 2018
Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.
Ref: #19263
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes