Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not check text for engine-generated error #19215

Closed
wants to merge 1 commit into from

Commits on Mar 8, 2018

  1. test: do not check text for engine-generated error

    In test-tls-wrap-event-emitter, the text of a TypeError is checked as
    part of the test. However, this text is generated by the JavaScript
    engine (V8) and not Node.js. Thus, we should not check the text as JS
    engine error messages can change without it being considered a breaking
    change for Node.js.
    
    A side effect is that node-chakracore will no longer need to patch this
    test to pass.
    Trott committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    d7e1eea View commit details
    Browse the repository at this point in the history