Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add convenience ctor for async trigger id scope #19204

Closed
wants to merge 1 commit into from
Closed

src: add convenience ctor for async trigger id scope #19204

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2018

Splitting this out from #18936

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 7, 2018
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2018

CI: https://ci.nodejs.org/job/node-test-commit/16761/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2018
@addaleax
Copy link
Member Author

Landed in d3f174f

@addaleax addaleax closed this Mar 11, 2018
@addaleax addaleax deleted the async-id-trigger-scope-convenience branch March 11, 2018 17:30
addaleax added a commit that referenced this pull request Mar 11, 2018
@addaleax
src: add convenience ctor for async trigger id scope
d3f174f 
PR-URL: #19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Mar 17, 2018
@addaleax @targos
src: add convenience ctor for async trigger id scope
9899a1d 
PR-URL: #19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@addaleax @MylesBorins
src: add convenience ctor for async trigger id scope
49481d0 
PR-URL: #19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax @MayaLekova
src: add convenience ctor for async trigger id scope
b011308 
PR-URL: nodejs#19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Jun 30, 2018
@addaleax
src: add convenience ctor for async trigger id scope
13d50d4 
This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

PR-URL: nodejs#19204
@addaleax addaleax mentioned this pull request Jun 30, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
@addaleax @MylesBorins
src: add convenience ctor for async trigger id scope
0d41b02 
This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

Backport-PR-URL: #21600
PR-URL: #19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
src: add convenience ctor for async trigger id scope
9125e2b 
This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

Backport-PR-URL: #21600
PR-URL: #19204
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @danbev @jasnell @joyeecheung @nodejs-github-bot