Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minor refactoring #19130

Closed
wants to merge 1 commit into from
Closed

test: minor refactoring #19130

wants to merge 1 commit into from

Conversation

ken23421
Copy link
Contributor

@ken23421 ken23421 commented Mar 4, 2018

change to arrow functions

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

change to arrow functions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 4, 2018
@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

Looks good, but needs a manual test as CI doesn't test internet tests.

@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

@ken23421
Copy link
Contributor Author

ken23421 commented Mar 5, 2018

@gibfahn Thanks for your comment. I tested it with the following command, and the result looks ok.

$ python tools/test.py -J --mode=release test/internet/test-http-https-default-ports
[00:01|% 100|+   1|-   0]: Done

Do you have other suggestion of the manual test? Thank you.

@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

Do you have other suggestion of the manual test? Thank you.

Nope that's perfect, just wanted to make sure someone had tried it. Thanks!

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 6, 2018
@ken23421
Copy link
Contributor Author

ken23421 commented Mar 8, 2018

Thanks @gibfahn
Wondering is there anything else TBD before landing?

@gibfahn
Copy link
Member

gibfahn commented Mar 9, 2018

Landing...

@gibfahn
Copy link
Member

gibfahn commented Mar 9, 2018

Landed in 06e09b6

@gibfahn gibfahn closed this Mar 9, 2018
gibfahn pushed a commit that referenced this pull request Mar 9, 2018
Use arrow functions.

PR-URL: #19130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gibfahn
Copy link
Member

gibfahn commented Mar 9, 2018

@ken23421 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@ken23421
Copy link
Contributor Author

@gibfahn Thanks a lot for your help :)

targos pushed a commit that referenced this pull request Mar 17, 2018
Use arrow functions.

PR-URL: #19130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Mar 18, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Use arrow functions.

PR-URL: #19130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Use arrow functions.

PR-URL: nodejs#19130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
Use arrow functions.

PR-URL: nodejs#19130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
Use arrow functions.

Backport-PR-URL: #22380
PR-URL: #19130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants