doc: new team for bundlers or delivery of Node.js #19098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager
This was referenced Mar 2, 2018
|
Will create actual team and solicit membership once this PR lands (meaning we have agreed on the name) |
richardlau
approved these changes
Mar 2, 2018
ljharb
reviewed
Mar 2, 2018
doc/onboarding-extras.md
Outdated
| @@ -41,6 +41,7 @@ | |||
| | upgrading libuv | @saghul | | |||
| | upgrading npm | @fishrock123, @MylesBorins | | |||
| | upgrading V8 | @nodejs/v8, @nodejs/post-mortem | | |||
| | Embedded use or delivery of Node.js | @nodejs/delivery_channels | | |||
There was a problem hiding this comment.
Can we make sure that @nodejs/version-management becomes a child team of delivery_channels?
There was a problem hiding this comment.
Nit: Definitely not a fan of using _ when all our other teams use - to separate words. Let's not make people guess which punctuation to use with which team! :-D
There was a problem hiding this comment.
(We use _ where it's what a module is using, but otherwise, we use - as far as I can tell. So this should be -.)
There was a problem hiding this comment.
@ljharb will look to make it a subteam of the new team. Not exactly sure what that will take but I'll figure it out.
gireeshpunathil
approved these changes
Mar 3, 2018
jasnell
approved these changes
Mar 5, 2018
|
@Trott updated. |
|
CI was good, landing. |
|
Landed as bd0a7a4 |
mhdawson
added a commit
that referenced
this pull request
Mar 5, 2018
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2018
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: nodejs#19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
No need to land this in 8.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add team that we can use to cc organizations or people
who do one of the following:
This would be the description I would add when creating the team itself:
This team is used to be able to communicate with organizations or people who do
one of the following:
If you are making a change to node core or elsewhere that might affect these parties
please include an @nodejs/delivery-channels in the issue.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc