Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update list of re-exported symbols #19013

Closed
wants to merge 1 commit into from
Closed

doc: update list of re-exported symbols #19013

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

libuv and zlib symbols are also purposefully re-exported by Node.js for
use in Addons.

Refs: #17444

  • make -j4 lint-md (UNIX) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@richardlau
doc: update list of re-exported symbols
afe8c56 
libuv and zlib symbols are also purposefully re-exported by Node.js for
use in Addons.

Refs: nodejs#17444
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Feb 26, 2018
@richardlau
Copy link
Member Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/200/

@mmarchini mmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 27, 2018
@richardlau richardlau self-assigned this Mar 2, 2018
@richardlau
Copy link
Member Author

Landed in 9e9c516

@richardlau richardlau closed this Mar 2, 2018
richardlau added a commit that referenced this pull request Mar 2, 2018
@richardlau
doc: update list of re-exported symbols
9e9c516 
libuv and zlib symbols are also purposefully re-exported by Node.js for
use in Addons.

Refs: #17444

PR-URL: #19013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to addaleax/node that referenced this pull request Mar 5, 2018
@richardlau @addaleax
doc: update list of re-exported symbols
77154cd 
libuv and zlib symbols are also purposefully re-exported by Node.js for
use in Addons.

Refs: nodejs#17444

PR-URL: nodejs#19013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@richardlau @MayaLekova
doc: update list of re-exported symbols
ea080ea 
libuv and zlib symbols are also purposefully re-exported by Node.js for
use in Addons.

Refs: nodejs#17444

PR-URL: nodejs#19013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@richardlau @jasnell
doc: update list of re-exported symbols
aaa6fe5 
libuv and zlib symbols are also purposefully re-exported by Node.js for
use in Addons.

Refs: nodejs#17444

PR-URL: nodejs#19013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@richardlau @MylesBorins
doc: update list of re-exported symbols
c2978ac 
libuv and zlib symbols are also purposefully re-exported by Node.js for
use in Addons.

Refs: #17444

Backport-PR-URL: #22380
PR-URL: #19013
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@mmarchini mmarchini mmarchini approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@richardlau richardlau

Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@richardlau @jasnell @cjihrig @hiroppy @mmarchini @gireeshpunathil @BridgeAR @nodejs-github-bot