Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: http2 client ping errors #18849

Closed
wants to merge 1 commit into from
Closed

test: http2 client ping errors #18849

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 18, 2018

This code change adds tests for the following errors in ping(payload, callback)

node/lib/internal/http2/core.js

Lines 946 to 955 in 472cde6

if (payload && !isArrayBufferView(payload)) {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE',
'payload',
['Buffer', 'TypedArray', 'DataView']);
}
if (payload && payload.length !== 8) {
throw new errors.RangeError('ERR_HTTP2_PING_LENGTH');
}
if (typeof callback !== 'function')
throw new errors.TypeError('ERR_INVALID_CALLBACK');

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2018
BridgeAR
BridgeAR approved these changes Feb 18, 2018
View reviewed changes
test/parallel/test-http2-ping.js
// Only max 2 pings at a time based on the maxOutstandingPings option
assert(!client.ping(common.expectsError({
code: 'ERR_HTTP2_PING_CANCEL',
type: Error,
message: 'HTTP2 ping cancelled'
})));

// should throw if payload is not of type ArrayBufferView
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please always use a capital letter as first letter in a comment and punctuate the comments as well.

@BridgeAR
Copy link
Member

BridgeAR commented Feb 18, 2018 •
edited
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/13248/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2018
jasnell pushed a commit that referenced this pull request Feb 20, 2018
@trivikr @jasnell
test: http2 client ping errors
1e57a8d 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 20, 2018

Landed 1e57a8d

@jasnell jasnell closed this Feb 20, 2018
@trivikr trivikr deleted the test-http2-ping branch February 20, 2018 15:59
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@trivikr @MylesBorins
test: http2 client ping errors
662d0cd 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@trivikr @MylesBorins
test: http2 client ping errors
baf1acc 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@trivikr @MylesBorins
test: http2 client ping errors
b7e6ac7 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@trivikr @MayaLekova
test: http2 client ping errors
9ab6b57 
PR-URL: nodejs#18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins

This comment has been minimized.

Sign in to view
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@trivikr @MylesBorins
test: http2 client ping errors
83b9e80 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@trivikr @MylesBorins
test: http2 client ping errors
4e56e31 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@trivikr @MylesBorins
test: http2 client ping errors
dba19ac 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@trivikr @MylesBorins
test: http2 client ping errors
a8ae04d 
PR-URL: #18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trivikr @BridgeAR @jasnell @MylesBorins @lpinca @cjihrig @nodejs-github-bot